@dysfunc Can you please fix the lock file as the build is failing.

Might be good to update the actions as well as I think the latest story book requires node 18+. Would just be good to target LTS (v20)

@dysfunc I think we might need to upgrade npm actions to node 20, I can't even run master branch locally due to esm failures.

@dysfunc I think we might need to upgrade npm actions to node 20, I can't even run master branch locally due to esm failures.

What errors are you seeing? I can install, build, run storybook on 16+

There were precommit hooks were failing for me with a lot of esm related messages. Looks like two of the github actions are failing, one of them with esm message. Thanks again for all of your help. I think the deps being so out of date is making this harder than normal. That will be the next thing I handle after this pr

I fixed the size test. The only one left is the editorconfig. It's failing on .git directory which should be ignored.

Thanks, I'm going to merge this and then fix that in a separate pr.

@dysfunc just noticed this

https://github.com/SauravKanchan/svelte-chartjs/actions/runs/7716442819/job/21033255322

All good!
 ERR_PNPM_NO_IMPORTER_MANIFEST_FOUND  No package.json (or package.yaml, or package.json5) was found in "/home/runner/work/svelte-chartjs/svelte-chartjs/dist".
Error: Process completed with exit code 1.

I can't think of anything off the top of my head that would cause this other than possibly the old process was outputting a package file?

the old process did copy package.json. the new process doesn't; it uses the root package.

This is the first time I've used pnpm, kinda looks like we need to copy it.

it shouldn't be copied over. I'm looking at it right now

i think the publishConfig might be the issue. that can be removed

  "publishConfig": {
    "directory": "dist"
  },

It used to be there for the package folder?

"publishConfig": {
    "directory": "package"
  },

I would remove that and rerun publish